----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129371/#review101773 -----------------------------------------------------------
Ship it! Also tested in an 'old' environment with kdepimlibs4 (libkdepimlibs4-4.11.5) and libgpgme (libgpgme11-1.4.4) and it works well. Since I am one of the developers, I provide the requested ship it. - Thomas Baumgart On Jan. 2, 2017, 12:19 vorm., Andreas Sturmlechner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129371/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2017, 12:19 vorm.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > Remove bogus qgpgme include. > > REVIEW: 129371 > > Make kdepimlibs optional > > Based on b5de50ccaa1571c4feb0c17ea8016554e3b822d7 from master. > > REVIEW: 129371 > > > Diffs > ----- > > CMakeLists.txt 22515185dcb2bdb6a9027101270ff97d445008b6 > kmymoney/dialogs/settings/ksettingsschedules.cpp > da138a7ab138d2f5ef1e8f5b7ad636f9a1964343 > kmymoney/kmymoney.cpp 3b3352b7abc83b60fe0e8156d48e7be439fb8964 > libkdchart/kdablibfakes/src/KDABLibFakes.h > f47ec24423a2ca61b04a98069351539e738fe572 > libkgpgfile/CMakeLists.txt a41a6a408e3da8769308dae75d4f514aa969dc87 > libkgpgfile/kgpgfile.cpp b1870be92edb833ed30f369e3e0ca0f320fe147b > > Diff: https://git.reviewboard.kde.org/r/129371/diff/ > > > Testing > ------- > > Built successfully (so far only tested with GpgME++ 1.7.1 and without > kdepimlibs-4). > Also built fine on a system with Gpgme 1.7.1 (no Gpgmepp bindings) and > kdepimlibs-4 installed. > > > Thanks, > > Andreas Sturmlechner > >
