----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129371/#review100789 -----------------------------------------------------------
Cool, does this mean, that one won't need kdepimlibs anymore when building KMM? :-) - Marko Käning On Nov. 10, 2016, 7:13 p.m., Andreas Sturmlechner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129371/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2016, 7:13 p.m.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > Gives kmymoney-4 some extended life on systems that upgrade to KDE > Applications 16.12 and are required to upgrade to kdepimlibs-conflicting > GpgME-1.7.0 by the latest version of KDE PIM. > > Remove bogus qgpgme include. > Make kdepimlibs optional (based on b5de50ccaa1571c4feb0c17ea8016554e3b822d7 > from master) > > > Diffs > ----- > > CMakeLists.txt 22515185dcb2bdb6a9027101270ff97d445008b6 > kmymoney/dialogs/settings/ksettingsschedules.cpp > da138a7ab138d2f5ef1e8f5b7ad636f9a1964343 > kmymoney/kmymoney.cpp a4251f031cee280983aa67c55447d3f97865dcbd > libkdchart/kdablibfakes/src/KDABLibFakes.h > f47ec24423a2ca61b04a98069351539e738fe572 > libkgpgfile/CMakeLists.txt a41a6a408e3da8769308dae75d4f514aa969dc87 > libkgpgfile/kgpgfile.cpp b1870be92edb833ed30f369e3e0ca0f320fe147b > > Diff: https://git.reviewboard.kde.org/r/129371/diff/ > > > Testing > ------- > > Built successfully (so far only tested with GpgME++ 1.7.1 and without > kdepimlibs-4). > Also built fine on a system with Gpgme 1.7.1 (no Gpgmepp bindings) and > kdepimlibs-4 installed. > > > Thanks, > > Andreas Sturmlechner > >
