----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129081/#review99815 -----------------------------------------------------------
Looks good to me (as usual: only done code reading). If you are happy with it, then ship it. - Thomas Baumgart On Okt. 2, 2016, 11:55 vorm., Łukasz Wojniłowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129081/ > ----------------------------------------------------------- > > (Updated Okt. 2, 2016, 11:55 vorm.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > 1) renamed redefinedlg.cpp to transactiondlg.cpp, > 2) merged RedefineDlgDecl and RedefineDlg, > 3) initialize transactiondlg only when it's needed, > 4) fit size of transactiondlg to content, > 5) connected slotAccepted and slotRejected in ui file, > 6) removed redundant variables, > 7) displayLine doesn't need to know what it displays, > 8) add column headers to transactiondlg, > 9) it doesn't matter if transaction type is unrecognised or invalid, > > > Diffs > ----- > > kmymoney/plugins/csvimport/CMakeLists.txt 6c57307 > kmymoney/plugins/csvimport/csvwizard.cpp 3867cd8 > kmymoney/plugins/csvimport/investmentwizardpage.h 574c4b6 > kmymoney/plugins/csvimport/investmentwizardpage.cpp 5917e65 > kmymoney/plugins/csvimport/redefinedlg.h 9594a90 > kmymoney/plugins/csvimport/redefinedlg.cpp b7ca3f4 > kmymoney/plugins/csvimport/redefinedlgdecl.ui 12c6191 > kmymoney/plugins/csvimport/transactiondlg.h PRE-CREATION > kmymoney/plugins/csvimport/transactiondlg.cpp PRE-CREATION > kmymoney/plugins/csvimport/transactiondlg.ui PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129081/diff/ > > > Testing > ------- > > > Thanks, > > Łukasz Wojniłowicz > >
