----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129082/ -----------------------------------------------------------
Review request for KMymoney. Repository: kmymoney Description ------- This patch does what it's intended to do, but I'm not completly satisfied with it. I wonder why I get lots of errors of this type ./kmymoney/kmymoney/plugins/csvimport/tests/symbol-test.cpp:34: undefined reference to `Parse::Parse()' if I use **kmm_csvimport** instead of **csvimport_tests** in code block below ``` file(GLOB tests_sources "*-test.cpp") ecm_add_tests(${tests_sources} NAME_PREFIX "csvimport-" LINK_LIBRARIES Qt5::Test csvimport_tests ) ``` if **kmm_csvimport** is **MODULE** instead of **STATIC**. Can somebody explain it to me and knows how to do it without **csvimport_tests**? Diffs ----- kmymoney/plugins/csvimport/tests/CMakeLists.txt f5b148e Diff: https://git.reviewboard.kde.org/r/129082/diff/ Testing ------- Thanks, Łukasz Wojniłowicz