----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129014/#review99597 -----------------------------------------------------------
kmymoney/plugins/csvimport/bankingwizardpage.cpp (line 93) <https://git.reviewboard.kde.org/r/129014/#comment66975> You're right, this is the drawback. I thought about it myself but did not see any problems. So don't worry too much about my suggestion. - Thomas Baumgart On Sept. 25, 2016, 3:50 nachm., Łukasz Wojniłowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129014/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2016, 3:50 nachm.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > csvwizard.cpp has many lines of code, so it's good to separate banking > page from it. The outcome is: > > 1) m_pageBanking is initialized only when it's needed, > 2) combo boxes on m_pageBanking are initialized only when needed, > 3) removed registered fields, because there is no need to use them on > other pages, > 4) merged csvdialog with bankingwizardpage, so there is no ping-pong > communication between them, > 5) used only one slot for every combo box, > 6) removed redundant includes, > 7) tidied up names and structure of investmentwizardpage. > > > Diffs > ----- > > kmymoney/plugins/csvimport/CMakeLists.txt 46cdc16 > kmymoney/plugins/csvimport/bankingwizardpage.h PRE-CREATION > kmymoney/plugins/csvimport/bankingwizardpage.cpp PRE-CREATION > kmymoney/plugins/csvimport/csvdialog.h d1e935c > kmymoney/plugins/csvimport/csvdialog.cpp 9385d9b > kmymoney/plugins/csvimport/csvimporterplugin.h e2908e4 > kmymoney/plugins/csvimport/csvutil.h 108718e > kmymoney/plugins/csvimport/csvwizard.h 6fbb858 > kmymoney/plugins/csvimport/csvwizard.cpp 7f59af7 > > Diff: https://git.reviewboard.kde.org/r/129014/diff/ > > > Testing > ------- > > > Thanks, > > Łukasz Wojniłowicz > >
