----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128624/ -----------------------------------------------------------
(Updated Aug. 15, 2016, 9:18 p.m.) Status ------ This change has been marked as submitted. Review request for KMymoney. Changes ------- Submitted with commit c7e279b5f41d0d36de647279e1a640a2ccaa3eca by ?ukasz Wojni?owicz to branch master. Repository: kmymoney Description ------- 1) processQIFLine should identify fields by integers and not strings (better performance), 2) validation of debit and credit column contained unnecessary check and was complicated, 3) QIF creation is not essential to processing, 4) statements is not needed and consumed memory exponentially, 5) cleaner hash assignation, 6) lots of redundant variables. createMemoField is commented for now but won't be after I rewrite processInvestLine. Diffs ----- kmymoney/plugins/csvimport/csvdialog.h 65bbeb7 kmymoney/plugins/csvimport/csvdialog.cpp 6d91d63 kmymoney/plugins/csvimport/csvwizard.h 2743685 kmymoney/plugins/csvimport/csvwizard.cpp b042a98 Diff: https://git.reviewboard.kde.org/r/128624/diff/ Testing ------- Thanks, Łukasz Wojniłowicz
