> On July 20, 2016, 5:55 a.m., Thomas Baumgart wrote: > > Your patch in general seems OK if you only have OFX accounts. It will > > interfere though with other online transaction downloads e.g. HBCI. > > > > Since the problem and the solution are very OFX specific, I suggest to move > > the logic into the OFX plugin. I would move the calculation of the > > **startDate** into **bool OfxImporterPlugin::import(const QString& > > filename)** and the filter logic at the end of **int > > OfxImporterPlugin::ofxTransactionCallback(struct OfxTransactionData data, > > void * pv)** where unhandled transaction types are already eliminated. > > Jack Ostroff wrote: > Thomas: do any of the other import types use the concept of a requested > start date for transactions? (I know csv does not, and have very limited > experience with anything except OFX.) Also, I think this only applies to OFX > direct connect, not to OFX file import, in case that affects the > implementation. > > Thomas Baumgart wrote: > In fact, KBanking supports this concept from day one and does so pretty > well. The German bank servers obey the options in the request (I have not > heard otherwise) whereas the Citibank server seems to be ignoring them > completely. Your hint about import vs. online download is valid. One could > catch this if the calculation for **startDate** is moved to **bool > OfxImporterPlugin::updateAccount(const MyMoneyAccount& acc, bool > moreAccounts)** which is only called for online updates AFAICS and leave it > at 1.1.1900 for all other paths. > The KBanking logic btw. can be found in **bool > KBankingPlugin::updateAccount(const MyMoneyAccount& acc, bool moreAccounts)**.
Just because there is only one current example of a server not honoring the start date, and it happens to be OFX, would it hurt to have ALL online imports drop transactions prior to the requested start date? - Jack ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128478/#review97637 ----------------------------------------------------------- On July 18, 2016, 5:44 p.m., Jeff Lundblad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128478/ > ----------------------------------------------------------- > > (Updated July 18, 2016, 5:44 p.m.) > > > Review request for KMymoney. > > > Bugs: 365818 > http://bugs.kde.org/show_bug.cgi?id=365818 > > > Repository: kmymoney > > > Description > ------- > > Only import transactions that are newer than or equal to the "Start date of > import" in the account's online settings > > > Diffs > ----- > > "a/kmymoney/kmymoney/converter/mymoneystatementreader-1b81833-left.cpp" > 0b31377 > > Diff: https://git.reviewboard.kde.org/r/128478/diff/ > > > Testing > ------- > > Tested on Citi credit card OFX downloads which nearly always download 2 years > worth of transactions regardless of the date range that the OFX request > requests. > > > Thanks, > > Jeff Lundblad > >
