I believe Cristian's comments were directed to the author of the commit, looped-in.
cheers, Łukasz (the other one ;)) 2016-06-18 20:24 GMT+02:00 Cristian Oneț <onet.crist...@gmail.com>: > Is the start line always greater than zero? Isn't it 0 based like all > sane programming structures which use indexes? > > On a side note, when committing bugfixes to thr 4.8 branch make sure > that the following conditions are met: > 1. Use the FIXED-IN tag to describe the version in which the fix will > be available 4.8.1 (the next release) [1], [2] > 2. Follow that your commits get cherry-picked in master by someone if > you don't do that yourself > 3. Only commit essential stuff like bugfixes and try to avoid changing > too much code because 4.8 is a dead end branch and merging to master > could be painful because of the possible conflicts (the more lines are > changed the higher the probability of a conflict) > > A general note about the CSV importer in master. A bunch of files > making up the CSV importer are just copy pasted and the code is way > too verbose and contains too much deprecated API. During the removal > of kdelibs4 support a lot of code was simply disabled (search for > "TODO: port to kf5"). I will not invest any of my time into porting > that unmaintainable code so someone must need to step up and do this > job otherwise the CSV importer will either be removed or rewritten > before a 5.0 release. > > Regards, > Cristian > > [1] https://techbase.kde.org/Development/Git/Configuration#Commit_Template > [2] https://community.kde.org/20110213_GitWorkflowAgenda#Commit_Template > > 2016-06-18 19:23 GMT+02:00 Łukasz Wojniłowicz < > lukasz.wojnilow...@gmail.com>: > > Git commit 28fbbe52fb98bc1e6add434670b5fcd359c357c4 by Łukasz > Wojniłowicz. > > Committed on 18/06/2016 at 17:14. > > Pushed by wojnilowicz into branch '4.8'. > > > > Set start line to one during CSV import > > > > Initial value of m_startLine should always be greater than zero. Shall > > user have start line greater than one, it will be set by appropriate > > slot. > > > > M +2 -2 kmymoney/plugins/csvimport/investprocessing.cpp > > > > http://commits.kde.org/kmymoney/28fbbe52fb98bc1e6add434670b5fcd359c357c4 > > > > diff --git a/kmymoney/plugins/csvimport/investprocessing.cpp > b/kmymoney/plugins/csvimport/investprocessing.cpp > > index 34e53c8..7562c73 100644 > > --- a/kmymoney/plugins/csvimport/investprocessing.cpp > > +++ b/kmymoney/plugins/csvimport/investprocessing.cpp > > @@ -104,7 +104,7 @@ InvestProcessing::InvestProcessing() > > m_detailColumn = -1; > > m_endLine = 0; > > m_fileEndLine = 0; > > - m_startLine = 0; > > + m_startLine = 1; > > m_topLine = 0; > > m_row = 0; > > m_endColumn = 0; > > @@ -2038,7 +2038,7 @@ void InvestProcessing::readSettings() > > > m_csvDialog->m_wiz->m_pageInvestment->ui->comboBoxInv_securityName->setCurrentIndex(tmp); > > > > tmp = m_startLine; > > - m_startLine = profilesGroup.readEntry("StartLine", -1) + 1; > > + m_startLine = profilesGroup.readEntry("StartLine", 0) + 1; > > if (m_startLine > m_endLine) { > > m_startLine = tmp; > > } > > > -- pozdrawiam, Łukasz
