----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128247/#review96708 -----------------------------------------------------------
How about moving those two (almost) identical parts into a method? Would that be possible? kmymoney/plugins/csvimport/csvdialog.cpp (line 604) <https://git.reviewboard.kde.org/r/128247/#comment65340> How about if(!m_inFileName.endswith(QDir::seperator)) kmymoney/plugins/csvimport/csvdialog.cpp (line 607) <https://git.reviewboard.kde.org/r/128247/#comment65337> qDebug() << "Source:" << m_url.toDisplayStrin() << "Destination:" << m_inFilename; is a lot easier than using the 'old style' printf syntax. kmymoney/plugins/csvimport/investprocessing.cpp (line 291) <https://git.reviewboard.kde.org/r/128247/#comment65339> See previous suggestions - Thomas Baumgart On Juni 19, 2016, 10:08 vorm., Łukasz Wojniłowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128247/ > ----------------------------------------------------------- > > (Updated Juni 19, 2016, 10:08 vorm.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > It makes "Select File" button usable again. I made native file dialogs > forbidden, because they seem hard to customize for me at this point. > > > Diffs > ----- > > kmymoney/plugins/csvimport/csvdialog.h 45586ff > kmymoney/plugins/csvimport/csvdialog.cpp d14017b > kmymoney/plugins/csvimport/investprocessing.h fe42429 > kmymoney/plugins/csvimport/investprocessing.cpp b266479 > > Diff: https://git.reviewboard.kde.org/r/128247/diff/ > > > Testing > ------- > > I loaded an my banking and investment statements. > > > Thanks, > > Łukasz Wojniłowicz > >
