----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128204/#review96557 -----------------------------------------------------------
Ship it! I verified that it compiles, links and runs in my KDE4 environment on the 4.8 branch. - Thomas Baumgart On Juni 16, 2016, 9:14 vorm., Cristian Oneț wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128204/ > ----------------------------------------------------------- > > (Updated Juni 16, 2016, 9:14 vorm.) > > > Review request for KMymoney and Thomas Baumgart. > > > Bugs: 364355 > http://bugs.kde.org/show_bug.cgi?id=364355 > > > Repository: kmymoney > > > Description > ------- > > Do this by backporting the change that is already in frameworks in commit > 77085ff468336f26f6bcf5f2a1a08e16409172e6. Did not use cherry pick because the > testfile was moved in frameworks. > > BUG: 364355 > > > Diffs > ----- > > kmymoney/mymoney/storage/mymoneymap.h > 0392d060112c3b0520342ac58c7a9974b0c18de8 > kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.cpp > dcb4b4a420e8d926ea8cbcb96d6e0bc4add1d3c2 > > Diff: https://git.reviewboard.kde.org/r/128204/diff/ > > > Testing > ------- > > Did not even compile it because I don't have a KDE4 dev environment right now. > > > Thanks, > > Cristian Oneț > >