https://bugs.kde.org/show_bug.cgi?id=351874
--- Comment #6 from Jeff <jeffjl....@outlook.com> --- Hi Łukasz, There is still a problem with the QIF import with your change. My test file also tested the case where the commission was greater than the proceeds from the sale (which can happen when trading options.) Your fix changed a "sell" trade that actually cost money into one that brought in money. The example in my test file was the "sell" of the "NFLX Aug 18 2012 110.0 Call". The price is 0.02, times 100 shares = 2.00. The commission is 10.77. So income of 2.00, outgo of 10.77 makes the total -8.77 (as shown in the U and T values in the QIF file). The cash account should decrease by 8.77. Your change turned that into a positive 8.77, and increased the cash account. This is admittedly a corner case, and I think I am the only KMM user that trades options because I have made a bunch of other changes to the KMM code to support that. So, to support my particular needs, I am going to undo your change in my local copy and restore my QIF importer change (which I submitted to the review board on Aug 15, 2015 but was never accepted). And still claim that the master branch does not fix my problem. (Though I hardly use QIF import anymore. I was using it to transfer my data from Quicken to KMM. I do have one investment account that doesn't support OFX and I use QIF for that one.) And I know that without your change, my OFX imports have been working. I don't have a quick and easy test for OFX import. But my review board submittal for the QIF importer change says I made the QIF importer data look just like the OFX importer data. Thus my concern in comment #3 about OFX testing with your change. I suspect OFX will work except for the case I explained in my first paragraph. Which probably nobody but me cares about :-) Jeff. -- You are receiving this mail because: You are the assignee for the bug.
