> On April 26, 2016, 10:07 p.m., Christian David wrote: > > Ship It! > > Cristian Oneț wrote: > AFAIK app.setQuitOnLastWindowClosed(false); was added because quiting is > handled by some custom code which makes sure that the user is prompted to > save the file if the file is dirty. If this still works on frameworks with > that line removed feel free to ship it. Also please test the import feature > using the DBUS call, practically while kmymoney is running if you call > kmymoney test.ofx from a shell test.ofx should be imported in the open > instance of kmymoney.
The "Do you want to save?" dialog is build into the window, therefore it is not affected by this patch (tested it). If I call ```kmymoney test.ofx``` a new windows is opened, with and without the patch. So a bug seems to be somewhere else. - Christian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127556/#review94877 ----------------------------------------------------------- On April 2, 2016, 8:37 p.m., Christian David wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127556/ > ----------------------------------------------------------- > > (Updated April 2, 2016, 8:37 p.m.) > > > Review request for KMymoney and Cristian Oneț. > > > Repository: kmymoney > > > Description > ------- > > Allow QApplication to quit if all windows were closed. Otherwise > KMyMoney would never shut down. > > Used this commit for minor changes which simplify the code. > > Most important is the removal of ```app.setQuitOnLastWindowClosed(false);```. > Is there a reason why it was added? > > > Diffs > ----- > > kmymoney/kmymoney.cpp 0d0a317d753e9c48740180d13235163928687b2c > kmymoney/main.cpp cf77030aeb7de0f744bc2cf928514568d564e2e8 > > Diff: https://git.reviewboard.kde.org/r/127556/diff/ > > > Testing > ------- > > Started and closed the app. > > > Thanks, > > Christian David > >
