----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127712/#review94911 -----------------------------------------------------------
kmymoney/plugins/csvimport/investprocessing.cpp (line 858) <https://git.reviewboard.kde.org/r/127712/#comment64443> Is this local variable really necessary? - Cristian Oneț On April 22, 2016, 6:56 p.m., Łukasz Wojniłowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127712/ > ----------------------------------------------------------- > > (Updated April 22, 2016, 6:56 p.m.) > > > Review request for KMymoney. > > > Bugs: 360747 > http://bugs.kde.org/show_bug.cgi?id=360747 > > > Repository: kmymoney > > > Description > ------- > > Fixes bug #360747. Current routine doesn't calculate columns well when > FieldDelimiter=DecimalSymbol. parseLine() from csvutil.cpp does it > properly. > > > Diffs > ----- > > kmymoney/plugins/csvimport/investprocessing.cpp 73e4e4d > > Diff: https://git.reviewboard.kde.org/r/127712/diff/ > > > Testing > ------- > > 1) CSV file where FieldDelimiter=DecimalSymbol=comma (Test file from bug > #360747) > 2) CSV file where FieldDelimiter=comma and DecimalSymbol=dot > > > Thanks, > > Łukasz Wojniłowicz > >
