----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127678/#review94753 -----------------------------------------------------------
Hi Mitch, according to the [Qt Docu](http://doc.qt.io/qt-5/qmetatype.html#qRegisterMetaType-1) ```qRegisterMetaType``` is (only) needed under some circumstances: To use the type T in QVariant, using Q_DECLARE_METATYPE() is sufficient. To use the type T in queued signal and slot connections, qRegisterMetaType<T>() must be called before the first connection is established. To prevent complicated issues if we use queued connections ourself in the future the ```qRegisterMetaType``` should go somewhere else. I think it should be ```mymoneymoney.cpp``` for ```MyMoneyMoney``` but I am unsure here. - Christian David On April 18, 2016, 1:03 a.m., Mitch Frazier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127678/ > ----------------------------------------------------------- > > (Updated April 18, 2016, 1:03 a.m.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > Register metatypes to eliminate Qt Desinger warnings. > > Registering metatypes for a type used in a widget eliminates > the following types of warnings from Qt Designer on start up > (displayed when designer is started from a console window): > > QMetaProperty::read: Unable to handle unregistered datatype > '<class>' for property '<class>::<member>' > > > Diffs > ----- > > kmymoney/widgets/kmymoneycurrencyselector.cpp 41be539 > kmymoney/widgets/kmymoneyedit.cpp ac79db7 > > Diff: https://git.reviewboard.kde.org/r/127678/diff/ > > > Testing > ------- > > Tested dialogs that use the data types. > > > Thanks, > > Mitch Frazier > >
