----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123177/ -----------------------------------------------------------
Review request for KMymoney. Repository: kmymoney Description ------- If a payment account that has a different currency than the currency of the loan is selected in the loan wizard, the resulting scheduled transaction would not have the proper value in the currency of the payment account. Fixed this by requesting the user to perform the currency conversion from the amount of the payment in the currency of the loan to the amount in the currency of the payment account. This conversion is done using the standard mechanism provided by the currency selector. After this was fixed I observed that the amount of the scheduled transaction was not being rendered properly in the homepage. Fixed this by using the same amount formating that is used in the ledger. BUG: 325793 Diffs ----- kmymoney/views/khomeview.cpp fac3343d17b0da47ad5a92cf9390658c87c6a420 kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp 473defc58ac9d194c5fe2b8f0fd662025305ba82 Diff: https://git.reviewboard.kde.org/r/123177/diff/ Testing ------- Created multiple loans, seems to works as expected, although I still need to test loan editing. The loan wizard has a few more bugs but I intend to file separate bug reports for those issues. Thanks, Cristian Oneț
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
