----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122545/#review76022 -----------------------------------------------------------
Ship it! Looks OK to me. - Thomas Baumgart On Feb. 12, 2015, 8:08 nachm., Christian David wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122545/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2015, 8:08 nachm.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > Added the obligatory context menu with "new", "edit" and "remove" > options to a context menu to the outbox for onlineJobs. > > This breaks with a KMyMoney design concept where the actions connect to > a slot in KMyMoneyApp. Naturally the edit and remove slots should be in > the onlineJobs view (as that is the place where the edit and remove > takes place). So the action is connected to the view directly. > > Is this okay for you? > > > Diffs > ----- > > kmymoney/kmymoney.h d0011dd2c3dd5fd3efd5c6b3c1be15e2baa6b5c5 > kmymoney/kmymoney.cpp 1af957d05e5ed3bb183e1f98a33ee5e964979ccc > kmymoney/kmymoneyui.rc f2ceb2e731133b5e3680ab3d740ff6393a1e314b > kmymoney/views/kmymoneyview.h 00fcb78dd2c2ae89ccbe793b7a44ae4c401ddf30 > kmymoney/views/kmymoneyview.cpp b103b8bd4b30800e869b64bc526e4e8c1bdc01af > kmymoney/views/konlinejoboutbox.h 6dc52685f30ad7b6deb8f8db95ff7ff2906f6921 > kmymoney/views/konlinejoboutbox.cpp > a05821a924d0b4e75864cdd2981859c88284c89a > > Diff: https://git.reviewboard.kde.org/r/122545/diff/ > > > Testing > ------- > > Manual test of new Ui, ```make test``` > > > Thanks, > > Christian David > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
