----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119207/#review69918 -----------------------------------------------------------
kmymoney/mymoney/mymoneycontact.h <https://git.reviewboard.kde.org/r/119207/#comment48915> should be MYMONEYCONTACT_H according to the filename - Thomas Baumgart On Okt. 18, 2014, 11:04 vorm., Cristian Oneț wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119207/ > ----------------------------------------------------------- > > (Updated Okt. 18, 2014, 11:04 vorm.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > Refactor the contact fetching code into a single class. > > This avoids code duplication and makes it easier to transform > the kdepimlibs dependency into an optional one. If kdepimlibs > is not detected the user will not be able to load contact data > from the address book (big deal...). > > It also makes it easier to fetch contact data from other parts of the > code, like for a payee. > > I'm not sure about putting this into the kmm_mymoney library but since > it only contains a data source and we don't have another lib for these > kind of objects it ended up here. > > REVIEW: 119207 > > > Diffs > ----- > > CMakeLists.txt dd3191d80f969b11c596c02dc101065cc4aaf3d7 > config-kmymoney.h.cmake 5f3845a46413259d60302ba1b921a266ee3bb1f9 > kmymoney/dialogs/knewfiledlg.h 92004714c8bedf8b1cf15bfc1e0f20edcab3a66c > kmymoney/dialogs/knewfiledlg.cpp b7233a181f8368734a75fbeaa976220f1fad319c > kmymoney/mymoney/CMakeLists.txt 38b3f44dc79250e0a45f031a691a042d49daa550 > kmymoney/mymoney/mymoneycontact.h PRE-CREATION > kmymoney/mymoney/mymoneycontact.cpp PRE-CREATION > kmymoney/wizards/newuserwizard/knewuserwizard.cpp > 7fd250cfc46db505dd8a1b595a2179c91e0183d9 > kmymoney/wizards/newuserwizard/knewuserwizard_p.h > adb4ca564cdd4b70e8cb4c4f1d053c0bd6335c38 > > Diff: https://git.reviewboard.kde.org/r/119207/diff/ > > > Testing > ------- > > Tested the "Load from addressbook" feature, it works. Also compiled the > module without finding the kdepimlibs module, it worked. > > > Thanks, > > Cristian Oneț > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
