> On Oct. 29, 2014, 1:59 p.m., Cristian Oneț wrote: > > Could the fact that writeFileInfo() is now used be causing this bug? > > https://bugs.kde.org/show_bug.cgi?id=339103
Soory, I just noticed your comment https://bugs.kde.org/show_bug.cgi?id=339103#c9 are you saying this would actually fix that bug? By looking at the upgradeToV7() I don't really understand why the tags code is there in the first place. Since we didn't had tags before there should be nothing to upgrade. - Cristian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120499/#review69451 ----------------------------------------------------------- On Oct. 5, 2014, 11:53 a.m., Christian David wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120499/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2014, 11:53 a.m.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > MyMoneyStorageSql::upgradeToV7() does not use readFileInfo() and > writeFileInfo() anymore. > > This should prevent an issue if this metod is used to upgrade the > database to a version higher than 7 as readFileInfo() and > writeFileInfo() assume a database of the most recent version. This > will cause errors (=> crash) if a column in kmmFileInfo was > renamed or added between version 7 and the final version. > > KMyMoney should still crash if you upgradeToV1() is used. > > > Diffs > ----- > > kmymoney/mymoney/storage/mymoneystoragesql.cpp > 0fa790d435bc978279038893b945de31811f34f1 > > Diff: https://git.reviewboard.kde.org/r/120499/diff/ > > > Testing > ------- > > Opened an sqlite database which was created with KMyMoney 4.5.3, database > version 6. > The upgrade still worked and kmmFileInfo was still filled with correct data. > > > Thanks, > > Christian David > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
