On 18/09/14 12:08, Cristian OneČ› wrote:
OK, but where is the patch? Please post a review request.

Regards,
Cristian

I'd been hoping to have it tested first, before submitting it, as I can't test on XP, but it looks like that's a non-starter. This is a pain. I'll do a review request later.

Any thoughts on the behaviour of the radio buttons that Jack sees? I just don't any such problem on Linux.

Allan

2014-09-18 13:22 GMT+03:00 Allan <agande...@gmail.com>:
I'd intended to cc this to the list, in case anyone can offer
comment/explanation.

The patch I refer to is to address the incorrect display of the CSV import
plugin, when on Windows and Ubuntu.  I'm only able to test on Ubuntu, where
all now looks fine.

It consists mainly of modified UI files, with only a minimal code change,
needed for the new UI's plus a small fix for a problem with decimal symbol
handling which could/and did sometimes result in a crash.

I've produced it now as two Windows users have experienced this problem, so
I'll also need a Windows tester able to compile and apply the patch, purely
to verify that the UI now looks correct, rather than to test the CSV
capability.

Thanks

Allan


-------- Forwarded Message --------
Subject: Re: [kmymoney4] [Bug 339044] CSV import wizard does not appear to
be working.
Date: Thu, 18 Sep 2014 00:43:54 +0100
From: Allan <agande...@gmail.com>
To: Jack Ostroff <ostrof...@sbcglobal.net>

On 17/09/14 22:57, Jack Ostroff wrote:

Allan,

I finally got a chance to work with the Windows version for a while.

The radio button issue is very strange.  With the mouse, I can click on
either radio button, but the only effect is a slight highlight of the
circle, not an actual selection.  However, I can use the keyboard to
select, and it seems to work fine.  On the other buttons, I'm pretty
sure they are actually there, just below the bottom of the window -
actually a pixel or two (or maybe three?) is visible, because if I tab
out of the radio buttons, I can see something change, indicating
activating one of the buttons or perhaps the file name field.  I even
managed to get the file selector to pop up,  using some combination of
tab and space.  So - it looks like the main issue is just display and
layout.

Let me know if do still want me to check those patches on Linux.

Jack


That is strange.  I've looked at the code,  and those two radio buttons
are handled the same way as on the Banking/Investment pages, and all the
other ordinary buttons  They respond to a 'clicked signal', and the only
way I could see a problem with that is the pointer has to be within the
button, when pressed and when released, so if the user moved off too
quickly it might not get picked up.

I'll copy this to the dev list as well in case anyone else can throw any
light.  But, I've pressed those buttons hundreds of times with no
problem at all.  However, if two Windows users, including you, have hit
it.....  I could use the pressed signal as well, if that may help.

So far as the patch is concerned, it might be worthwhile to try on
another distro, but then you've used the git HEAD version.  I'll forward
it off-line, as it's fairly large, with the UI's being changed.

Allan



_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Reply via email to