Bump this up so we don't forget to fix it.
2014-08-19 13:54 GMT+03:00 Cristian Oneț <onet.crist...@gmail.com>:
> Hi,
>
> I agree with you that approach b would be the best. I must have missed
> that since I'm using cmake 2.8.12.2. The same applies to kmymoney.
>
> Regards,
> Cristian
>
> 2014-08-19 13:46 GMT+03:00 Thomas Baumgart <t...@net-bembel.de>:
>> Hi folks (mainly Cristian),
>>
>> I just updated my alkimia repo and cannot compile it anymore (branch master)
>> :
>> ( The problem is the following construct that Cristian has introduced:
>>
>> target_link_libraries(alkimia PUBLIC ${QT_QTCORE_LIBRARY}
>> ${QT_QTDBUS_LIBRARY}
>> ${GMP_LIBRARIES})
>>
>> where I get the following link error:
>>
>> Linking CXX shared library ../lib/libalkimia.so
>> /usr/lib64/gcc/x86_64-suse-linux/4.8/../../../../x86_64-suse-linux/bin/ld:
>> cannot find -lPUBLIC
>> collect2: error: ld returned 1 exit status
>>
>> Looks like PUBLIC is not used as one thought it would be used. A bit of
>> reading the CMAKE docs revealed the following:
>>
>> a) the keyword PUBLIC is supported as of cmake 2.8.12 (I do have 2.8.11.2
>> here)
>>
>> b) in earlier versions, the keyword was LINK_PUBLIC and was introduced in
>> cmake 2.8.7
>>
>> http://www.cmake.org/cmake/help/v2.8.7/cmake.html#command:target_link_libraries
>>
>> c) Our CMakeLists.txt states 2.8.6 being the minimum version to be used
>>
>> So what do we do to fix this problem?
>>
>> a) set the minimum version required to 2.8.12
>> b) set the minimum version required to 2.8.7 and s/PUBLIC/LINK_PUBLIC/
>> c) ??? I don't know
>>
>> Implications:
>>
>> a) we will certainly hit those people using distros that don't ship 2.8.12
>> yet. I am on openSUSE 13.1, so fairly new.
>>
>> b) that should solve the problem for those using 2.8.7+ where 2.8.7 was
>> released on 30.12.2011. I don't know, how this works for those using cmake
>> 2.8.12+
>>
>> So, what do you think? My current suggestion is to use b) and work around any
>> problem that shows up with cmake 2.8.12+.
>>
>> @Cristian: can you comment on this? Maybe Marko as well, as this might have
>> some influence on this Mac OS X stuff.
>>
>> --
>>
>> Regards
>>
>> Thomas Baumgart
>>
>> GPG-FP: E55E D592 F45F 116B 8429 4F99 9C59 DB40 B75D D3BA
>> -------------------------------------------------------------
>> Computers let you make more mistakes faster than any other
>> invention in human history, with the possible exception
>> of handguns and tequila. --Mitch Radcliffe
>> -------------------------------------------------------------
>>
>> _______________________________________________
>> KMyMoney-devel mailing list
>> KMyMoney-devel@kde.org
>> https://mail.kde.org/mailman/listinfo/kmymoney-devel
>>
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
