> On Aug. 23, 2014, 10:43 a.m., Cristian Oneț wrote: > > Ship It! > > Cristian Oneț wrote: > Although the currency symbol could be made configurable in the URL. For > fund in euro, like http://funds.ft.com/uk/Tearsheet/Summary?s=ES0102562032:EUR > > Thomas Baumgart wrote: > Right, but we only have the symbol of the security. This is something the > user must take care of, since we don't know which currency to use at this > point. Also, this is a completely different URL.
OK, then ship it :). - Cristian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119911/#review65087 ----------------------------------------------------------- On Aug. 23, 2014, 10:40 a.m., Thomas Baumgart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119911/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2014, 10:40 a.m.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > This patch shall support "Financial Times UK Funds" as source for online > price quotes again. Apparently their format changed. I received this patch a > long time ago via e-mail and just found it sitting in my stash. Before I add > it to master, I wanted someone to review it. > > > Diffs > ----- > > kmymoney/converter/webpricequote.cpp 7b1d24d > > Diff: https://git.reviewboard.kde.org/r/119911/diff/ > > > Testing > ------- > > Compile, Link, Run the application but no testing towards the new source > > > Thanks, > > Thomas Baumgart > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
