On 10/04/14 09:50, Chris wrote:
Hi Allan Thank you for that
I get errors when I tried to apply the patch. I thought I might be
behind so I pulled in the latest master but it results in the same
errors it seems you might be patching a commit or branch I don't have.
git apply --check
0001-Modify-CSV-importer-settings-and-UI-to-correct-appea.patch
error: patch failed: kmymoney/plugins/csvimport/bankingwizardpage.ui:6
error: kmymoney/plugins/csvimport/bankingwizardpage.ui: patch does not
apply
error: patch failed: kmymoney/plugins/csvimport/csvdialog.cpp:105
error: kmymoney/plugins/csvimport/csvdialog.cpp: patch does not apply
error: patch failed: kmymoney/plugins/csvimport/csvdialog.h:168
error: kmymoney/plugins/csvimport/csvdialog.h: patch does not apply
error: patch failed: kmymoney/plugins/csvimport/introwizardpage.ui:48
error: kmymoney/plugins/csvimport/introwizardpage.ui: patch does not apply
error: patch failed: kmymoney/plugins/csvimport/investmentwizardpage.ui:6
error: kmymoney/plugins/csvimport/investmentwizardpage.ui: patch does
not apply
I also was doing some testing last night and I found the layout errors
change between builds. I have seen this sort of error before. Often it
is the result of a un-initialised variable. I also realised I may have
another issue. for no particular reason I have been building kmymoney as
32bit app perhaps the behaviour I am seeing is an improperly initialised
int or a pointer problem due to the change in word length.
Just guesswork so far I haven't committed to recompiling the entire
library as 64bit yet to test it
Chris
Hi Chris
That's strange. All five files failed?!! I can't see it being a commit
problem. Nobody else has worked on them, at least for a couple of
years, so they should be in step.
I wonder if you tried on Windows rather that Ubuntu? I produced them
under Ubuntu, and for all files to fail, I'm wondering if you were on
Windows, and whether it's a line-ending problem, which would affect all
the files, of course.
I hadn't really thought about that previously, but I guess the file will
need to be edited for Windows. There are only three lines which affect
the immediate performance of the plugin, those at line 149-151 in
csvdialog.cpp, if you wanted to see to what extent, or if, they might
help or change your issue.
Allan
Allan
On 8/04/2014 9:48 PM, Allan wrote:
Hi Chris
Here's the patch for you to try. For me, it looks OK on Ubuntu now,
so should be OK for you, too. Windows, we'll see if it helps, but I
can't see it making any difference so far as the Title bars are
concerned.
Let's know how it goes. There are some outstanding issues with
scrolling and resizing. I'm pretty close with those but didn't want
to make more changes until this first lot is tried.
Allan
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
