> On March 18, 2014, 10:38 p.m., Cristian Oneț wrote: > > I was going to push this but before I did I gave it a try. I have the > > following remarks that can be seen in this video > > http://kmymoney2.sourceforge.net/screencasts/110212.ogv > > > > If I try to merge two payees why can't I select one of them as the target? > > At leas that I what I expected from a merge function. Also the merge action > > is missing from the context menu. The merge dialog can be closed with enter > > without performing any action by typing a payee's name that is selected for > > merge. > > > > Could you please address this issues? At least convince me that this is the > > right way it should work. > > > > Christian David wrote: > "If I try to merge two payees why can't I select one of them as the > target? At leas that I what I expected from a merge function." I think if you > merge several payees you should be able to select only one of the selected > ones to merge into. > > If you have to select a different payee, it is a delete operation. > > Felipe Tonello wrote: > Ok. I see your point. So the list of possible payees should be those > selected? I guess the user should be able to merge into a new payee as well. > > And I will fix the context menu thing.
BTW, I added the payee_merge action to the payee_context_menu in kmymoneyui.rc but it doesn't work. Any ideas on how to do it? - Felipe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110212/#review53385 ----------------------------------------------------------- On March 11, 2014, 10:18 a.m., Felipe Tonello wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/110212/ > ----------------------------------------------------------- > > (Updated March 11, 2014, 10:18 a.m.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > payee: Does not merge when payees are empty > > When there is no transactions to be merged we don't need to merge. In fact if > we don't stop there the rest of the code will delete the payees, which is a > behavior for delete payees functionality. > > Signed-off-by: Felipe F. Tonello <e...@felipetonello.com> > > payee: Show transactions from multiple payees > > This patch allow users to have see all transactions that they > will merge. > > Signed-off-by: Felipe F. Tonello <e...@felipetonello.com> > > payee: Added Payees Merge KButton > > Adds a button next to the delete payee and enables it only when multiple > payees are selected. > > Signed-off-by: Felipe F. Tonello <e...@felipetonello.com> > > payee: Added payee_merge KAction > > Added KAction to the context menu and connected to the slotPayeeMerge(). > > Signed-off-by: Felipe F. Tonello <e...@felipetonello.com> > > payee: Added support to Merge Payees > > This patch implements the opeartion to merge payees. This is done by reusing > the payee delete slot, modifying it to support merge operation and add support > to it in KPayeeReassignDlg dialog. > > The main difference between delete a payee and merging a payee is that when > merging the user can merge to a new payee. So the modification was done to > support this use-case. > > Signed-off-by: Felipe F. Tonello <e...@felipetonello.com> > > payee: change slotPayeeNew(...) to return boolean value > > This is usefull if the user of that function wants to know if the user created > a new payee or not. > > Signed-off-by: Felipe F. Tonello <e...@felipetonello.com> > > payee: Make PayeeReassignDlg support other operations then delete > > This is useful so it can be implemented a merge opration and maybe others in > future as well. > > Signed-off-by: Felipe F. Tonello <e...@felipetonello.com> > > payee: Better explanation when deleting payee > > Signed-off-by: Felipe F. Tonello <e...@felipetonello.com> > > > Diffs > ----- > > kmymoney/dialogs/kpayeereassigndlg.h > a348d2b9fdc68a7c56a616a862a3373ef35aa0ba > kmymoney/dialogs/kpayeereassigndlg.cpp > 8bdb25c0b3478c42715fac9f052903ed45b3614c > kmymoney/dialogs/kpayeereassigndlgdecl.ui > 2cf563d4ea755e8d89ff2587fa677f14453cbaa5 > kmymoney/kmymoney.h 56e0bd6a3de42bdaa3fbb2f8586495cbb4d555ca > kmymoney/kmymoney.cpp 6b96b9790d0ee5b5d34e6cfd382b03e9a103c9e6 > kmymoney/kmymoneyui.rc 65afc920cef7091e3138c9acf75f73ec96929445 > kmymoney/views/kpayeesview.h c747e691f6509c7bf60201dfb3cc77e9f939a7c5 > kmymoney/views/kpayeesview.cpp 7252241886e05f00555d16dc1388b9d6ecef36a2 > kmymoney/views/kpayeesviewdecl.ui 6efb2ae5f94383851ee2ab15da36187b7079815a > > Diff: https://git.reviewboard.kde.org/r/110212/diff/ > > > Testing > ------- > > Normal UI test going trough all the possible options of users input. > > > Thanks, > > Felipe Tonello > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
