----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110212/#review51654 -----------------------------------------------------------
Other than the things I mentioned this looks OK to me. kmymoney/kmymoney.cpp <https://git.reviewboard.kde.org/r/110212/#comment36715> Please make sure to align all new icons with the work Alvaro just added to the master branch. kmymoney/kmymoney.cpp <https://git.reviewboard.kde.org/r/110212/#comment36716> I am not sure, why you duplicate payee_id into newPayeeName here. - Thomas Baumgart On Feb. 15, 2014, 3:06 a.m., Felipe Tonello wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/110212/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2014, 3:06 a.m.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > It implements Payee Merge operation. > > To be able to make this I had to change KPayeeReassignDlg to support other > operations then delete. Also I used the delete payee slot and created a new > function since merge and delete operations are very similar, avoiding code > duplication. > > > Diffs > ----- > > kmymoney/dialogs/kpayeereassigndlg.h > a348d2b9fdc68a7c56a616a862a3373ef35aa0ba > kmymoney/dialogs/kpayeereassigndlg.cpp > 8bdb25c0b3478c42715fac9f052903ed45b3614c > kmymoney/dialogs/kpayeereassigndlgdecl.ui > 2cf563d4ea755e8d89ff2587fa677f14453cbaa5 > kmymoney/kmymoney.h 56e0bd6a3de42bdaa3fbb2f8586495cbb4d555ca > kmymoney/kmymoney.cpp 426ddc93962a4d44e42301c146e90c648c96c035 > kmymoney/kmymoneyui.rc 65afc920cef7091e3138c9acf75f73ec96929445 > kmymoney/views/kpayeesview.h c747e691f6509c7bf60201dfb3cc77e9f939a7c5 > kmymoney/views/kpayeesview.cpp 69697e6f34505c597cacd97f6516fbdaf708f4ae > kmymoney/views/kpayeesviewdecl.ui 6efb2ae5f94383851ee2ab15da36187b7079815a > > Diff: https://git.reviewboard.kde.org/r/110212/diff/ > > > Testing > ------- > > > Thanks, > > Felipe Tonello > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
