----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115338/#review50037 -----------------------------------------------------------
This review has been submitted with commit 0a3ef042a8bd7494c5bae192e76a1818beb5c96f by Allan Anderson to branch master. - Commit Hook On Jan. 27, 2014, 5:33 p.m., Allan Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115338/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2014, 5:33 p.m.) > > > Review request for KMymoney. > > > Bugs: 319801 > http://bugs.kde.org/show_bug.cgi?id=319801 > > > Repository: kmymoney > > > Description > ------- > > Follow-up patch on https://git.reviewboard.kde.org/r/115302/, > to fix handling of number field. > There was no check that a new 'next number' did not already exist. For > instance, if there is the sequence 22,23,24, and the user entered a new > transaction numbered 21, the 'next number' would have been 22, which already > exists. > Deletion of a numered transaction would produce an incorrect next number. > An edit of an existing number was not saved. > These issues, which exist also in the stable release, have been fixed. > (new Reviewboard item raised for this part, on suggestion of Thomas Baumgart). > > > Diffs > ----- > > kmymoney/kmymoneyutils.cpp e89528e > kmymoney/kmymoneyutils.h a899121 > kmymoney/kmymoney.cpp 7a2fd4f > kmymoney/dialogs/transactioneditor.cpp 3c148d8 > kmymoney/dialogs/transactioneditor.h db86832 > > Diff: https://git.reviewboard.kde.org/r/115338/diff/ > > > Testing > ------- > > Numerous manual test cases run. Unit tests run. > > > Thanks, > > Allan Anderson > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
