----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114767/#review48283 -----------------------------------------------------------
Ship it! I added one more tiny thing. Once the debug stuff Alvaro mentioned has gone it's ready to be shipped. kmymoney/wizards/newloanwizard/keditloanwizard.cpp <https://git.reviewboard.kde.org/r/114767/#comment34168> One more spot to use a const reference - Thomas Baumgart On Jan. 4, 2014, 12:27 a.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114767/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2014, 12:27 a.m.) > > > Review request for KMymoney. > > > Bugs: 257619 > http://bugs.kde.org/show_bug.cgi?id=257619 > > > Repository: kmymoney > > > Description > ------- > > Add ability to modify loan institution attribute. > > Add a new choice to editselectionwizardpage to modify only loan attributes. > Add a new loanattributes page to modify just institution for now, will add > other attributes next. > > BUG:257619 > REVIEW:114767 > > > Diffs > ----- > > kmymoney/wizards/newloanwizard/CMakeLists.txt > 939d569c2bba56ccfd3c9d6b28f8b90d414b9332 > kmymoney/wizards/newloanwizard/editselectionwizardpage.cpp > e8cf0353a6aa357f6fc3d818aa3819aa13cf25c5 > kmymoney/wizards/newloanwizard/editselectionwizardpagedecl.ui > 2e482c47f9a3642a880f0dcb047ca577c6e0446c > kmymoney/wizards/newloanwizard/keditloanwizard.cpp > 5590a359ffc16c92fc3dc24b6484aac1180b1507 > kmymoney/wizards/newloanwizard/knewloanwizard.h > 6b3f049912605f4f9cb0e78ee83b14e2767586b8 > kmymoney/wizards/newloanwizard/knewloanwizarddecl.ui > 831d85ce388b51a904c76cd998f54ca6a099b347 > kmymoney/wizards/newloanwizard/loanattributeswizardpage.h PRE-CREATION > kmymoney/wizards/newloanwizard/loanattributeswizardpage.cpp PRE-CREATION > kmymoney/wizards/newloanwizard/loanattributeswizardpagedecl.ui PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/114767/diff/ > > > Testing > ------- > > It works here to set and to show the current institution. > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
