----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112885/#review41232 -----------------------------------------------------------
Now that this review has been inadvertently posted to group kmymoney and not only to Jack I would be happy to get feedback from core developers whether the approach I have chosen here is acceptable. Please see my question at the end of the description. - Marko Käning On Oct. 4, 2013, 3:45 p.m., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112885/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2013, 3:45 p.m.) > > > Review request for KMymoney and Jack Ostroff. > > > Repository: kmymoney > > > Description > ------- > > This is an attempt of implementing an extended online balance highlighting in > ledger view. > > Three configuration options below "/Preferences/Ledger/Highlight > (non-matching) online balance" are available: > > 'disable' - no highlighting > > 'strict' - highlight always if online and file balance don't match > > 'relaxed' - highlight with orange if online and file balance don't match, > but cleared and online balance coincide > highlight only in red if cleared and online balance also don't > match > > --- > > To achieve the functionality I have to intercept in > KGlobalLedgerView::updateSummaryLine() > the account's cleared balance in kgloballedgerview.cpp using the new method > Register::setClearedBalance(). > In Register::addGroupMarkers() I then fetch the online balance using > Register::setOnlineBalance(). > > In GroupMarker::paintRegisterCell() I then use > Register::hasEqualOnlineAndClearedBalances() to decide > which colors to use for highlighting the group marker. > > My question: Is this approach acceptable, or should the functionality be > hidden in class MyMoneyFile, > just like in case of MyMoneyFile::hasMatchingOnlineBalance()? > > > Diffs > ----- > > .reviewboardrc 7ed8df159b8e4a8af81a3fe9b360e940bce548cc > kmymoney/dialogs/settings/ksettingsregisterdecl.ui > 049a985eb84707e0bce60a3c90206e948ff7ccec > kmymoney/kmymoney.kcfg 7a582fd4cbfbf657c0f2e5d3c9a3a1f20b0c939a > kmymoney/tips ab0a720bacad41c4efbbe390bbc2d4e33c498bc3 > kmymoney/views/kgloballedgerview.cpp > 000393cc150162eb4d954ae1dcbd7fdee68e60d0 > kmymoney/widgets/register.h 50ce7598783b49197de6acf4859a0fbd7c5c8962 > kmymoney/widgets/register.cpp d5dd63951d35b7098c0797fe64f10baf07a77fe1 > > Diff: http://git.reviewboard.kde.org/r/112885/diff/ > > > Testing > ------- > > Build, install, ran fine. > Config options get saved/restored as needed. > > > Thanks, > > Marko Käning > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
