> On Sept. 26, 2013, 10 a.m., Cristian Oneț wrote: > > kmymoney/dialogs/transactioneditor.cpp, line 464 > > <http://git.reviewboard.kde.org/r/112947/diff/1/?file=192725#file192725line464> > > > > Are you sure that this is valid since categoryId.clear() is > > called above? This only keeps the data in the widget. > > Allan Anderson wrote: > Yes it is. As explained above, the data in the widget is the name of the > interest category, but we're dealing now with a new fee category. If we > clear this text, the interest category has lost its name and it needs to be > added again once the fee category dialog closes. > It definitely fixes the issue, but whether there is something deeper, I > don't know. > > Cristian Oneț wrote: > See my question above, when accepting the transaction what will be the > value of 'categoryId' if it has been cleared and only the name was kept? Is > it being recomputed based on the name which was kept? > > Allan Anderson wrote: > 'categoryId' is empty on entry, in these circumstances - when adding a > new category. Editing an existing one doesn't come here. > > Cristian Oneț wrote: > OK, then it's safe. > > Allan Anderson wrote: > Not pushing, but want to be certain whether that means OK to ship, or > just you're OK with that particular point? Didn't want it to be in limbo. > Tidied up and retested. All looks OK with no flicker. >
I was waiting for the updated patch to fix the other issues we've discussed in this review request to give this patch the 'Ship it!'. - Cristian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112947/#review40849 ----------------------------------------------------------- On Sept. 26, 2013, 12:03 a.m., Allan Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112947/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2013, 12:03 a.m.) > > > Review request for KMymoney. > > > Bugs: 322768 > http://bugs.kde.org/show_bug.cgi?id=322768 > > > Repository: kmymoney > > > Description > ------- > > - Interest category disappears - > Steps to Reproduce: > 1.Open a new Dividend transaction. > 2.Enter an interest category and amount. > 3.Enter a new fee category. > 4.On accepting the new category, the interest category and amount have been > cleared. > One line fix in kmymoney/dialogs/transactioneditor.cpp. > > - Fixes for KEditWidget visibility issues. > When editing an investment transaction, interest or fee edit widgets show or > hide incorrectly. This is a fairly long-standing issue, and there have been > attempts to fix by delaying the show() or hide() instructions. This became > more pronounced during work to allow column resizing, and Cristian produced a > fix for the root cause. This fix is included here. > With the above fix in place, it became necessary to revert the delayed show() > and hide() calls, and this has been done. > Of course, nothing is ever as simple as that, and another couple of issues > emerged. Whether or not an interest or fee amount widget is shown depends on > the presence or absence of the associated category's text. It transpired > that if, say, an existing Reinvest transaction was edited to be, say a Buy > transaction, the text from the Reinvest interest category was seen by the > new Buy entry and resulted in the interest-amount widget being visible when > none should appear. Similarly, if a transaction with a fee set is edited to > be a type with no fee expected, for instance, an Add or RemoveShares, then > the fee-amount widget became visible when not needed. > It was necessary to rework the slotUpdateFeeVisibility() and > slotUpdateInterestVisibility() functions to take account of the new > transaction type. > > > Diffs > ----- > > kmymoney/dialogs/investactivities.cpp 50f33ed > kmymoney/dialogs/investtransactioneditor.h 3e62c2a > kmymoney/dialogs/investtransactioneditor.cpp e9f87fb > kmymoney/dialogs/transactioneditor.cpp 39049cf > kmymoney/widgets/transactioneditorcontainer.h f77b195 > > Diff: http://git.reviewboard.kde.org/r/112947/diff/ > > > Testing > ------- > > Entering and editing various transaction types to ensure only the appropriate > widgets became visible or hidden when required. > > > Thanks, > > Allan Anderson > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
