----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108666/#review36825 -----------------------------------------------------------
This review has been submitted with commit ace6e9657a5bef10f3f3ca9b69afdae9df7ec209 by Cristian Oneț to branch master. - Commit Hook On Feb. 7, 2013, 6:46 p.m., Cristian Oneț wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108666/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2013, 6:46 p.m.) > > > Review request for KMymoney. > > > Description > ------- > > This removes usage of the deprecated StdAddressBook API. Using the guide > provided at http://techbase.kde.org/Development/AkonadiPorting/AddressBook. > Unfortunately this does not work if you don't have nepomuk enabled (as I > later found out). I don't have nepomuk enabled because it keeps eating my > CPU/memory. I'll file a bug report later when I'll have time for this. Anyway > from my POV it's really stupid that this does not work without nepomuk (since > nepomuk can be disabled from systemsettings). ANy other ideas how should we > handle this? Should we ignore the warning for now? > > > Diffs > ----- > > CMakeLists.txt 93af070 > kmymoney/CMakeLists.txt 7fec1a9 > kmymoney/dialogs/knewfiledlg.h cb2a153 > kmymoney/dialogs/knewfiledlg.cpp c7b3ecb > kmymoney/wizards/newuserwizard/knewuserwizard.cpp d8a4ab2 > kmymoney/wizards/newuserwizard/knewuserwizard_p.h 9ec49d0 > > Diff: http://git.reviewboard.kde.org/r/108666/diff/ > > > Testing > ------- > > Version1: This query made virtuoso eat one of my processor's core so no > testing was done. > Version2: The user's data is loaded as expected. > > > Thanks, > > Cristian Oneț > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel