----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110587/#review33083 -----------------------------------------------------------
Ship it! Looks good to me. Please remove that one line mentioned in the review and ship it. kmymoney/views/kgloballedgerview.h <http://git.reviewboard.kde.org/r/110587/#comment24459> ??? This seems to be a leftover - Thomas Baumgart On May 22, 2013, 1:21 a.m., Allan Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110587/ > ----------------------------------------------------------- > > (Updated May 22, 2013, 1:21 a.m.) > > > Review request for KMymoney. > > > Description > ------- > > When I found recently that I couldn't edit multiple investment transactions, > and started to investigate, I discovered this old bug, which had resulted in > the disabling of the feature. I fixed the reported problem and re-enabled > that code. That fix was committed as > 3f45cfc6996f9c2cd2fa01dd0232051c50075651 on 2 April. When I investigated > further, I discovered there were some additional issues, which Thomas felt > should be left in abeyance pending a re-write of the Ledger code. > I then found that there was a potential danger of a user editing unlike > investment types and not noticing that one of the types could get changed > inadvertently without his noticing, particularly if a number of transactions > were being edited at once. This has therefore now been fixed and editing of > unlike investment types is no longer possible. > It was also noticed that the tooltips in this part of > /kmymoney/views/kgloballedgerview.cpp did not work as I expected, in that > there was no tooltip visible on the transaction in question, although it was > found that the tooltips were attached to the edit button. It was felt that > this wasn't very helpful, as the user might have attempted the edit from the > context menu or by double-click. So, I have added code to display error > information at the transaction position. I haven't done this for every error > message, where I was unable to determine how to produce the error condition. > However, I have covered the mixed investment types situation, multiple > splits, and flagging any attempt to edit where a closed account was involved. > The original code for tooltips has been left in place, however. > > > Diffs > ----- > > kmymoney/kmymoney.cpp 063f8b5 > kmymoney/views/kgloballedgerview.h 0041ea2 > kmymoney/views/kgloballedgerview.cpp 8a2c592 > > Diff: http://git.reviewboard.kde.org/r/110587/diff/ > > > Testing > ------- > > Ensured that attempts to edit unlike items is prevented, and also to create > or edit transactions where a closed account is involved. Unit test run > without error. > > > Thanks, > > Allan Anderson > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
