----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108398/#review25421 -----------------------------------------------------------
Ship it! starDate (which should have been named startDate in the first place) is a left-over from early versions. The reconciliation must go beyond the last statement date to catch valid transactions that could have been happened between the last transaction on the statement and the statement date itself. This is sometimes the case for credit card statements. - Thomas Baumgart On Jan. 13, 2013, 9:04 p.m., Łukasz Maszczyński wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108398/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2013, 9:04 p.m.) > > > Review request for KMymoney. > > > Description > ------- > > When compiling from a clean workspace, there is a bunch of compilation > warnings. Most of them seem pretty straighforward, but please note the fix > for 'starDate' variable: as far as I understand, currently the reconcilation > will be run from "the beginning", not from the date of last reconcilation, > which I believe was the author's intent when he defined 'starDate' variable. > Is that what is expected? > > fixed warning: variable 'it' set but not used > fixed warning: variable 'previousFiscalYear' set but not used > fixed warning: variable 'temp' set but not used > fixed warning: variable 'entry' set but not used > fixed warning: variable 'calculatedField' set but not used > fixed warning: variable 'starDate' set but not used > > > Diffs > ----- > > kmymoney/kmymoney.cpp 70c642e55548b3435e1c46d99e4ad19adb5970bd > kmymoney/plugins/kbanking/widgets/kbaccountlist.cpp > f403228ec9e55ae4578b6d3f7219d02731a1d67f > kmymoney/widgets/kmymoneydatetbl.cpp > a0c560e1d74d9795e45d3289158de8d6c73e0509 > kmymoney/widgets/register.cpp a469e7a8deac95da737c0227bccba62a0a208efe > kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp > 89916a273fc0c136c75373f0ace0e579fc0a930d > > Diff: http://git.reviewboard.kde.org/r/108398/diff/ > > > Testing > ------- > > compile > make test > > > Thanks, > > Łukasz Maszczyński > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
