> On Dec. 30, 2012, 9:19 a.m., Łukasz Maszczyński wrote: > >
Thanks Łukasz for reviewing this so quickly! :-) I added some remarks below in order to ask for input from perhaps Thomas (who supported me back then constructing my first test cases when I had balance-highlighting introduced into the ledger view, see review https://git.reviewboard.kde.org/r/103264/ ). I am not at all proficient enough in KDE or KMyMoney development to decide how to proceed with this. :( > On Dec. 30, 2012, 9:19 a.m., Łukasz Maszczyński wrote: > > kmymoney/mymoney/mymoneyfiletest.cpp, line 2080 > > <http://git.reviewboard.kde.org/r/107619/diff/2/?file=102889#file102889line2080> > > > > Is it really required to call testAddAccounts() here? I imagine this is > > the least effort to setup the ground for your test, but I'd rather extract > > some part of testAddAccounts() (it tests more than a single scenario, so > > this should not be a problem) into a new test and use that one. I used the same approach for the test case as back then for MyMoneyFile::hasMatchingOnlineBalance()! Other tests also make use of testAddAccounts() which is why I thought it was advisable to do so. (I also thought it would be better to re-use code which is tested in itself.) > On Dec. 30, 2012, 9:19 a.m., Łukasz Maszczyński wrote: > > kmymoney/mymoney/mymoneyfiletest.cpp, lines 2105-2108 > > <http://git.reviewboard.kde.org/r/107619/diff/2/?file=102889#file102889line2105> > > > > I'd split it into two test functions - you're testing two independent > > cases after all. I actually had 3 test cases encapsulated in one test in review 103264 which was said to be fine back then, which is why I followed the same strategy here. - Marko ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107619/#review24223 ----------------------------------------------------------- On Dec. 29, 2012, 10:05 p.m., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107619/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2012, 10:05 p.m.) > > > Review request for KMymoney. > > > Description > ------- > > The homepage accounts tables now show a different icon if there are > transactions for an account after the last online transaction - highlighting > for the user the necessity to download transactions in order to verify the > account status. > > > Diffs > ----- > > kmymoney/mymoney/mymoneyfile.h c43977ce7413eee2bc1e0a841fa548314c71e9df > kmymoney/mymoney/mymoneyfile.cpp 6640356d5e07152f8eb4aecff23d62ee8d853dbd > kmymoney/mymoney/mymoneyfiletest.h 5551fa94b6b34022c8e91c0301847d5479e6b1f2 > kmymoney/mymoney/mymoneyfiletest.cpp > feb9d57ecd7156fc1eea189a905fa797aeae9183 > kmymoney/views/khomeview.cpp c79337176b7265cabe15cad4972bc719e797af7c > > Diff: http://git.reviewboard.kde.org/r/107619/diff/ > > > Testing > ------- > > Built and ran application and test cases successfully. > > > Thanks, > > Marko Käning > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
