----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107758/#review23829 -----------------------------------------------------------
kmymoney/converter/mymoneystatementreader.cpp <http://git.reviewboard.kde.org/r/107758/#comment18203> You should use m_account.fraction() which returns the correct value needed here. Your assumption about the two variants is not quite correct. I agree, that the documentation of MyMoneySecurity is a bit sparse. Please take a look at the one for MyMoneyAccount::fraction(const MyMoneySecurity&) which shows what you need to know. Otherwise it looks good to me. - Thomas Baumgart On Dec. 22, 2012, 8:58 a.m., Łukasz Maszczyński wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107758/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2012, 8:58 a.m.) > > > Review request for KMymoney. > > > Description > ------- > > The dialog window which pops up when an imported transaction matches a > schedule now contains additional information helpful to the user: payee > information and transaction amount. This helps the user to identify if the > transaction and schedule should really be matched. > > > Diffs > ----- > > kmymoney/converter/mymoneystatementreader.h 886a5f1 > kmymoney/converter/mymoneystatementreader.cpp ef04d51 > > Diff: http://git.reviewboard.kde.org/r/107758/diff/ > > > Testing > ------- > > make test > > > Thanks, > > Łukasz Maszczyński > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
