-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107507/
-----------------------------------------------------------

(Updated Nov. 28, 2012, 8:19 p.m.)


Review request for KMymoney.


Changes
-------

The previous patch had some unnecessary includes.


Description
-------

KWallet API is pretty cumbersome if we need to do this kind of hacking to make 
it's usage safe.
I thought I'll put this one up for review to get your opinion about a fix like 
this.
I would have preferred using a progress dialog as a permanent parent for the 
open operation but this was faster to write.


This addresses bug 255764.
    http://bugs.kde.org/show_bug.cgi?id=255764


Diffs (updated)
-----

  kmymoney/kmymoney.cpp fafceb0 
  kmymoney/plugins/ofximport/dialogs/konlinebankingstatus.cpp faf7757 
  kmymoney/plugins/ofximport/dialogs/mymoneyofxconnector.h 5538a5d 
  kmymoney/plugins/ofximport/dialogs/mymoneyofxconnector.cpp 4fc0c0d 
  kmymoney/plugins/ofximport/ofximporterplugin.cpp 92dc76b 

Diff: http://git.reviewboard.kde.org/r/107507/diff/


Testing
-------

The main window can't be touched until the wallet dialog is dismissed one way 
or the other.


Thanks,

Cristian Oneț

_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Reply via email to