----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107138/#review22238 -----------------------------------------------------------
Ship it! Ship It! - Cristian Oneț On Oct. 30, 2012, 6:46 p.m., Łukasz Maszczyński wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107138/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2012, 6:46 p.m.) > > > Review request for KMymoney. > > > Description > ------- > > There are three possible options when it comes to payee matching for imported > transactions: > 1. no matching > 2. by payee name > 3. by list of keys > > When the 3rd option is selected it's easy to make a mistake and add a single > space as the match key - the user is unlikely to realize this, as "space key" > is not visible on the list (it's just a space, right?) unless selected. The > consequence of this mistake is that nearly all transactions will match the > payee (to be precise: all transactions which contain at least one space in > the 'payee' field). > > The "new" regular expression in the patch requires payee match key to contain > at least a single non-space character. > > This patch changes the algorithm of checking the match key: instead of > joining multiple match keys into a single string separated with semicolons > and matching the whole string with a regular expression, each match key is > checked with a regular expression separaterly (results in a simpler regular > expression). > > > Diffs > ----- > > kmymoney/mymoney/mymoneypayee.cpp 93e12c8 > kmymoney/mymoney/mymoneypayeetest.h d50d61d > kmymoney/mymoney/mymoneypayeetest.cpp 85ee7fd > > Diff: http://git.reviewboard.kde.org/r/107138/diff/ > > > Testing > ------- > > new UT written > make test > > > Thanks, > > Łukasz Maszczyński > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
