----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106434/#review18922 -----------------------------------------------------------
kmymoney/views/khomeview.h <http://git.reviewboard.kde.org/r/106434/#comment15001> I understand why you need to use a class member here. Please move it to the private object and reference it as either d->total or d->m_total. But '_total' does not follow our coding style. kmymoney/views/khomeview.cpp <http://git.reviewboard.kde.org/r/106434/#comment15000> Why do you use 10000 here? Doesn't MyMoneyFile::baseCurrency().smallestAccountFraction() yield a better result? - Thomas Baumgart On Sept. 12, 2012, 11:47 p.m., Alessandro Russo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106434/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2012, 11:47 p.m.) > > > Review request for KMymoney. > > > Description > ------- > > Add a row with the total at the end of the payment and preferred accounts > lists in the home view > > > Diffs > ----- > > kmymoney/views/khomeview.h ac78dfb > kmymoney/views/khomeview.cpp ac1ae7a > > Diff: http://git.reviewboard.kde.org/r/106434/diff/ > > > Testing > ------- > > > Thanks, > > Alessandro Russo > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
