----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104774/#review13495 -----------------------------------------------------------
This review has been submitted with commit 9fc583d3db4fe2c16448790d7ee17145fbe8bd2f by Alvaro Soliverez to branch master. - Commit Hook On April 30, 2012, 10:40 p.m., Alvaro Soliverez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104774/ > ----------------------------------------------------------- > > (Updated April 30, 2012, 10:40 p.m.) > > > Review request for KMymoney. > > > Description > ------- > > When running a non-base currency report, the individual splits of a > transaction were still being converted to the currency of the main split > (that gets selected on-the-fly by several criteria). > > This one has the potential to be very disruptive in other variations of > transaction reports, so it should be reviewed carefully > > > This addresses bugs 295533 and 297437. > http://bugs.kde.org/show_bug.cgi?id=295533 > http://bugs.kde.org/show_bug.cgi?id=297437 > > > Diffs > ----- > > kmymoney/reports/querytable.cpp ef809e8 > kmymoney/reports/querytabletest.h 0103190 > kmymoney/reports/querytabletest.cpp c9eba29 > > Diff: http://git.reviewboard.kde.org/r/104774/diff/ > > > Testing > ------- > > Tested with the provided test file, but I don't have an additional suitable > file to test all other cases. > > > Thanks, > > Alvaro Soliverez > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
