----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104786/#review13158 -----------------------------------------------------------
I am thinking about the following use-case: you have a time line of three dates: A -> B -> C where C is the date you ask a price for, B is a reciprocal value and A is the price info for the currencies you ask for. In case 'exactDate' is false, B would contain the correct answer. AFAICS, your patch does not cover this case, right? Other than that it's a start to solve the problem. - Thomas Baumgart On April 29, 2012, 7:05 p.m., Alvaro Soliverez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104786/ > ----------------------------------------------------------- > > (Updated April 29, 2012, 7:05 p.m.) > > > Review request for KMymoney and Thomas Baumgart. > > > Description > ------- > > There may be cases where only the reciprocal value for a given date is > present, but if there is a price for a previous date, the latter will be used > instead. > The fix here intends to use the most accurate value, which is the one in the > exact date, even if it's the reciprocal one. > > There might be performance issues. Perhaps a price cache should be considered > in the future. > > > This addresses bug 297437. > http://bugs.kde.org/show_bug.cgi?id=297437 > > > Diffs > ----- > > kmymoney/mymoney/mymoneyfile.cpp eef7126 > > Diff: http://git.reviewboard.kde.org/r/104786/diff/ > > > Testing > ------- > > Ran reports where this case is present, and unit tests. > There was no noticeable performance problem, but the set of prices was normal. > > > Thanks, > > Alvaro Soliverez > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
