I'm hoping to have another look at the code this week.
Ian
Cristian Oneț wrote:
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103456/
On January 2nd, 2012, 11:08 a.m., *Thomas Baumgart* wrote:
kmymoney/dialogs/keditscheduledlg.cpp
<http://git.reviewboard.kde.org/r/103456/diff/1/?file=43834#file43834line478>
(Diff revision 1)
void KEditScheduleDlg::slotRemainingChanged(int value)
464
m_FinalPaymentEdit->setDate(d->m_schedule.dateAfter(value));
466
m_FinalPaymentEdit->setDate(d->m_schedule.adjustedDate(d->m_schedule.dateAfter(value),
convertWeekendOption(m_weekendOptionEdit->currentIndex())));
I expect this to break the logic! Try what happens with the following
data: start 30.12.2011, end 1.1.2011, change date to previous processing day.
It should have 3 payments. Then save the entry and edit it again. Does it still
have 3 payments? BTW: I expect the latest patch attached to
https://bugs.kde.org/show_bug.cgi?id=290059 be installed.
On January 2nd, 2012, 11:17 a.m., *Thomas Baumgart* wrote:
Of course I mean 1.1.2012 to be the end date.
What is the status of this review request?
- Cristian
On December 18th, 2011, 9:20 p.m., Ian Neal wrote:
Review request for KMymoney.
By Ian Neal.
/Updated Dec. 18, 2011, 9:20 p.m./
Description
Changing remaining transactions on scheduled transaction with a weekend option
set can show an incorrect scheduled date
Testing
Tested with patch, edit scheduled transaction dialog only shows processing
dates when changing number of remaining transactions, best tested with a daily
repeating transaction with 30 transactions.
*Bugs: * 289306 <http://bugs.kde.org/show_bug.cgi?id=289306>
Diffs
* kmymoney/dialogs/keditscheduledlg.h
(83fc913bc0a9590f6194520f27641fbad160be67)
* kmymoney/dialogs/keditscheduledlg.cpp
(7ddf3c3edd763992960cb86e52c5bb6d68efb9e6)
View Diff <http://git.reviewboard.kde.org/r/103456/diff/>
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
