----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6791/#review10422 -----------------------------------------------------------
SVN commit 1254077 - Allan On Aug. 31, 2011, 11:53 a.m., Allan Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6791/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2011, 11:53 a.m.) > > > Review request for kmymoney. > > > Summary > ------- > > The problem shows best if the transaction form is enabled, but also is evident > without the form. > If an existing cash dividend transaction is selected, the form shows widgets > for Date, Amount, Total and Status, which is what is expected. > If that transaction is then opened for editing, additional widgets show for > Security, Quantity and Price, which aren't expected for a cash dividend. > If, while the transaction is open for editing, 'Dividend' is reselected, the > additional fields disappear. Similar behaviour occurs for Buy transactions. > > Also, in numerous places, the likes of - > QWidget* w = haveWidget(*it_s); > if (w) > w->hide(); > were found to produce unreliable results. > > Also, When a Dividend transaction is opened for editing, the fee category > field is > active, but there is no label. If a fee category is entered, the fee amount > field becomes active - again no label, and if an amount is entered, the total > reflects this change. However, when the transaction edit is accepted, the fee > amount has been lost. > > Also, fees have been removed from Dividends, and interest income has been > removed from > Buy and Sell, as these seem most unlikely combinations. > > I've noticed various other anomalies in the various investment types, to do > with unnecessary fields, missing labels and one where it's possible to enter a > value for a fee without a category, and which doesn't get retained. > > > This addresses bug 276322. > https://bugs.kde.org/show_bug.cgi?id=276322 > > > Diffs > ----- > > /trunk/extragear/office/kmymoney/kmymoney/dialogs/investactivities.cpp > 1250545 > > /trunk/extragear/office/kmymoney/kmymoney/dialogs/investtransactioneditor.cpp > 1250545 > /trunk/extragear/office/kmymoney/kmymoney/widgets/transaction.cpp 1250545 > > Diff: http://svn.reviewboard.kde.org/r/6791/diff > > > Testing > ------- > > Intensive testing of the ledger ui with dummy transactions, and live work. > Krazy2 and astyle run. > > > Thanks, > > Allan > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
