-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6779/
-----------------------------------------------------------
(Updated Aug. 29, 2011, 3:29 a.m.)
Review request for kmymoney.
Changes
-------
Fixed loopholes after testing. It turned out to be much more complicated than
expected.
In particular, for those cases where there was no specific account filter, and
then I had to rely on filtering only when it's an investment report.
Summary
-------
This will check investments subaccount for a non-zero balance or for
transactions during the time of the report, and only then it will add them to
the report to be shown.
It will have an impact on performance, but the accounts have to be added to the
report before knowing whether the stock is actually used or not.
This addresses bug 280368.
https://bugs.kde.org/show_bug.cgi?id=280368
Diffs (updated)
-----
trunk/extragear/office/kmymoney/kmymoney/reports/listtable.h 1249965
trunk/extragear/office/kmymoney/kmymoney/reports/listtable.cpp 1249965
Diff: http://svn.reviewboard.kde.org/r/6779/diff
Testing (updated)
-------
Tested with my own file, against investment and non-investment reports. The
performance does not seem ti be affected a great deal
Thanks,
Alvaro
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
