-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6777/
-----------------------------------------------------------

(Updated Aug. 24, 2011, 7:08 p.m.)


Review request for kmymoney.


Changes
-------

Updated patch to contain missing new file importoption.ui


Summary
-------

This patch allows to select the source of the payee information for file 
imports. It supports the same settings as the OFX direct connect version. The 
selection is (currently) non-persistent and defaults to the payee id field.


This addresses bug 271734.
    https://bugs.kde.org/show_bug.cgi?id=271734


Diffs (updated)
-----

  trunk/extragear/office/kmymoney/kmymoney/kmymoney.h 1249345 
  trunk/extragear/office/kmymoney/kmymoney/kmymoney.cpp 1249345 
  trunk/extragear/office/kmymoney/kmymoney/plugins/importinterface.h 1249345 
  
trunk/extragear/office/kmymoney/kmymoney/plugins/interfaces/kmmimportinterface.h
 1249345 
  
trunk/extragear/office/kmymoney/kmymoney/plugins/interfaces/kmmimportinterface.cpp
 1249345 
  trunk/extragear/office/kmymoney/kmymoney/plugins/ofximport/CMakeLists.txt 
1249345 
  trunk/extragear/office/kmymoney/kmymoney/plugins/ofximport/importoption.ui 
PRE-CREATION 
  
trunk/extragear/office/kmymoney/kmymoney/plugins/ofximport/ofximporterplugin.cpp
 1249345 

Diff: http://svn.reviewboard.kde.org/r/6777/diff


Testing
-------

Due to the lack of OFX files that require the setting to be changed, I only 
added some debug statements (which have been removed in the patch) to verify 
that the controlling variable d->m_preferName is setup correctly after the 
dialog is closed. Further processing should be identical to the OFX direct 
connect version.

Someone who needs this option should do some more testing and report about the 
results.


Screenshots
-----------

OFX file open dialog
  http://svn.reviewboard.kde.org/r/6777/s/618/


Thanks,

Thomas

_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Reply via email to