> On May 14, 2011, 4:59 a.m., Thomas Baumgart wrote: > > /trunk/extragear/office/kmymoney/kmymoney/dialogs/transactioneditor.cpp, > > line 642 > > <http://svn.reviewboard.kde.org/r/6674/diff/1/?file=46149#file46149line642> > > > > You need to use the securities trading currency here. So the code might > > look like > > > > MyMoneySecurity sec = file->security(account.security); > > > > and the price would use security.tradingCurrency() instead of the > > baseCurrency. > > Thomas Baumgart wrote: > Corr: It would use 'sec.tradingCurrency()'. Just to avoid confusing you. > > Thomas Baumgart wrote: > OT: Hm, in the future I should not do reviews before the second cup of > coffee in the morning. > > Of course it should have been > > MyMoneySecurity sec = file->security(account.currencyId()); >
Hopefully, I think I followed what was needed. The results come out the same, which is a good sign. > On May 14, 2011, 4:59 a.m., Thomas Baumgart wrote: > > /trunk/extragear/office/kmymoney/kmymoney/dialogs/transactioneditor.cpp, > > line 644 > > <http://svn.reviewboard.kde.org/r/6674/diff/1/?file=46149#file46149line644> > > > > I am not sure where the price source is used other than while > > displaying entries in the price list editor. I suggest to use a different > > string here to distinguish between a price entered by the user and one > > generated from entering a transaction. "Transaction" might be a good one > > but if you have a better one use it. I understand. "Transaction" seems fine here. > On May 14, 2011, 4:59 a.m., Thomas Baumgart wrote: > > /trunk/extragear/office/kmymoney/kmymoney/dialogs/transactioneditor.cpp, > > line 645 > > <http://svn.reviewboard.kde.org/r/6674/diff/1/?file=46149#file46149line645> > > > > 'file->' == 'MyMoneyFile::instance()' so you can reuse file here. OK. - Allan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6674/#review10107 ----------------------------------------------------------- On May 14, 2011, 11:50 a.m., Allan Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6674/ > ----------------------------------------------------------- > > (Updated May 14, 2011, 11:50 a.m.) > > > Review request for kmymoney. > > > Summary > ------- > > At the moment pricing information is retained only from imported transactions. > > This fix is to retain prices entered in manually added or edited transactions. > > > This addresses bugs 233236 and Bug. > https://bugs.kde.org/show_bug.cgi?id=233236 > https://bugs.kde.org/show_bug.cgi?id=Bug > > > Diffs > ----- > > /trunk/extragear/office/kmymoney/kmymoney/dialogs/transactioneditor.cpp > 1231885 > > Diff: http://svn.reviewboard.kde.org/r/6674/diff > > > Testing > ------- > > Astyle run. Several buy, sell and reinvestment transactions entered/edited. > > > Thanks, > > Allan > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
