Christoph Zwerschke wrote: > The problem was the short-circuit logic for "and". As soon as > succeeded was false, print_result was not called any more.
Of course. > I noticed another problem, namely that compile_file does not catch > errors as compile_dir does. I noticed that too but let it be as the raised exception served my purpose anyway of terminating the make run. But I agree that it's nicer for a friendly error to be provided. > Is this ok for you? Yes. I like that you have changed the exit codes from numbers to symbols. I didn't know that the os module defined them - that was useful to learn. While you are refactoring compile.py, what do you think about not making the name 'rslt' do double duty as in "rslt, file = rslt" and elsewhere? Hamish ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ kid-template-discuss mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kid-template-discuss
