From: Philipp Rudo on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3457#note_2181721298
Hi Vitaly, thanks for taking this over. I have a few minor issues about the crashkernel addon, although pretty nit-picky... 1. Personally I would name the addon 'crashkernel-default.addon'. At least in our team and documentation we always refer to the "default" value. So calling it "-std" might cause confusion. 2. The value you have chosen is the default value on x86. Experience however shows that aarch64 requires a little more memory. There the default value is 1G-4G:256M,4G-64G:320M,64G-:576M (for 4k kernels, 64k kernels require an additional ~100M). IIRC UKIs are supported on both x86 and aarch64. So I'm afraid we need to add arch specific addons. 3. While the default value should work in most cases it's not guaranteed to work. So I think we should also add addons to set the crashkernel parameter to a fixed, larger value. To have the flexibility to workaround those problems. All in all I would suggest the following changes to the commit ``` diff --git a/redhat/uki_addons/common/crashkernel-1536M.addon b/redhat/uki_addons/common/> crashkernel-1536M.addon new file mode 100644 index 000000000000..637a8ef4b459 --- /dev/null +++ b/redhat/uki_addons/common/crashkernel-1536M.addon @@ -0,0 +1 @@ +crashkernel=1536M diff --git a/redhat/uki_addons/common/crashkernel-192M.addon b/redhat/uki_addons/common/crashkernel-192M.addon new file mode 100644 index 000000000000..f0028982e426 --- /dev/null +++ b/redhat/uki_addons/common/crashkernel-192M.addon @@ -0,0 +1 @@ +crashkernel=192M diff --git a/redhat/uki_addons/common/crashkernel-1G.addon b/redhat/uki_addons/common/crashkernel-1G.addon new file mode 100644 index 000000000000..13424dc4ba30 --- /dev/null +++ b/redhat/uki_addons/common/crashkernel-1G.addon @@ -0,0 +1 @@ +crashkernel=1G diff --git a/redhat/uki_addons/common/crashkernel-256M.addon b/redhat/uki_addons/common/crashkernel-256M.addon new file mode 100644 index 000000000000..c4ea938f50f2 --- /dev/null +++ b/redhat/uki_addons/common/crashkernel-256M.addon @@ -0,0 +1 @@ +crashkernel=256M diff --git a/redhat/uki_addons/common/crashkernel-2G.addon b/redhat/uki_addons/common/crashkernel-2G.addon new file mode 100644 index 000000000000..7a046a23c0ad --- /dev/null +++ b/redhat/uki_addons/common/crashkernel-2G.addon @@ -0,0 +1 @@ +crashkernel=2G diff --git a/redhat/uki_addons/common/crashkernel-512M.addon b/redhat/uki_addons/common/crashkernel-512M.addon new file mode 100644 index 000000000000..91b380aa03d0 --- /dev/null +++ b/redhat/uki_addons/common/crashkernel-512M.addon @@ -0,0 +1 @@ +crashkernel=512M diff --git a/redhat/uki_addons/virt/common/crashkernel-std.addon b/redhat/uki_addons/common/crashkernel-default.addon similarity index 100% rename from redhat/uki_addons/virt/common/crashkernel-std.addon rename to redhat/uki_addons/common/crashkernel-default.addon diff --git a/redhat/uki_addons/virt/rhel/aarch64/crashkernel-default.addon b/redhat/uki_addons/virt/rhel/aarch64/crashkernel-default.addon new file mode 100644 index 000000000000..decd58e2e6ea --- /dev/null +++ b/redhat/uki_addons/virt/rhel/aarch64/crashkernel-default.addon @@ -0,0 +1 @@ +crashkernel=1G-4G:256M,4G-64G:320M,64G-:576M ``` -- _______________________________________________ kernel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
