From: Don Zickus <[email protected]> [CI] add exit 0 to the end of CI scripts
Both of the CI scripts (ark-create-release and ark-update-configs) end on a conditional that is usually non-zero in the normal case. That leads that non-zero status to be the exit code of the overall script and thus tells gitlab that things failed when actually they passed. ark-create-release.sh last line test "$TO_PUSH" && eval "$PUSH_CMD" # TO_PUSH is off right now ark-update-configs.sh last line grep -q "remote:[ ]* WARNINGS" $TMPFILE && die "Server side warnings" ( normally there is no server side warnings) Let's make sure the script returns success by adding an explicity 'exit 0' at the end. Fixes: #123 Signed-off-by: Don Zickus <[email protected]> diff --git a/redhat/scripts/ci/ark-create-release.sh b/redhat/scripts/ci/ark-create-release.sh index blahblah..blahblah 100755 --- a/redhat/scripts/ci/ark-create-release.sh +++ b/redhat/scripts/ci/ark-create-release.sh @@ -72,3 +72,5 @@ PUSH_CMD="git push gitlab ${BRANCH} && \\ echo "# $PUSH_VERB $PUSH_STR" echo "$PUSH_CMD" test "$TO_PUSH" && eval "$PUSH_CMD" + +exit 0 diff --git a/redhat/scripts/ci/ark-update-configs.sh b/redhat/scripts/ci/ark-update-configs.sh index blahblah..blahblah 100755 --- a/redhat/scripts/ci/ark-update-configs.sh +++ b/redhat/scripts/ci/ark-update-configs.sh @@ -110,3 +110,5 @@ fi # failure. Make sure all branches are pushed first as follow up # git-pushes may succeed. grep -q "remote:[ ]* WARNINGS" $TMPFILE && die "Server side warnings" + +exit 0 -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2626 _______________________________________________ kernel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
