From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/695#note_428972109
> > CKI Gitlab commented: > > Jiri Benc [email protected] commented via email: > > > The extra newline was a mistake that I saw when viewing the MR on > > gitlab, so I thought I would be quick and edit it using their web UI, > > but it deleted the newline at the end of the file. I added that > > newline back, and the V4 patch is now correct. So clearly, you are not > > nacking the patch for that reason. If you want to nack the series, > > that's fine, but some context would be worthwhile there. > > I explained it in v3: > > https://lists.fedoraproject.org/archives/list/[email protected] ct.org/message/HRAQ3Z2A5JXZGVZ2R3MPWO5O3HGED7O7/ > > Then you sent v4 without addressing this. Not sure what more I can do. > > What I expect is you sending v5 with just two patches. Patch 3 and > patch 4 should be folded into patch 1. > > Jiri The resulting changeset is still exactly as it should be, why be pedantic on rewriting history where it doesn't matter? https://gitlab.com/cki-project/kernel-ark/-/merge_requests/695/diffs _______________________________________________ kernel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]
