This bug is awaiting verification that the linux-kvm/5.15.0-1078.83
kernel in -proposed solves the problem. Please test the kernel and
update this bug with the results. If the problem is solved, change the
tag 'verification-needed-jammy-linux-kvm' to 'verification-done-jammy-
linux-kvm'. If the problem still exists, change the tag 'verification-
needed-jammy-linux-kvm' to 'verification-failed-jammy-linux-kvm'.


If verification is not done by 5 working days from today, this fix will
be dropped from the source code, and this bug will be closed.


See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how
to enable and use -proposed. Thank you!


** Tags added: kernel-spammed-jammy-linux-kvm-v2 
verification-needed-jammy-linux-kvm

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/2104380

Title:
  Build failure when CONFIG_NET_SWITCHDEV=n due to CVE-2024-26837 fix
  backport

Status in linux package in Ubuntu:
  Invalid
Status in linux source package in Jammy:
  In Progress

Bug description:
  [ Impact ]

  Since jammy:linux commit 0158242f01a0 ("net: bridge: switchdev: Skip
  MDB replays of deferred events on offload"), the kernel build fails
  when CONFIG_NET_SWITCHDEV=n, as observed in e.g. jammy:linux-kvm. The
  error is as follows:

    /build/jammy/net/bridge/br_mdb.c: In function 'br_mdb_queue_one':
    /build/jammy/net/bridge/br_mdb.c:640:13: error: implicit declaration of 
function
    'switchdev_port_obj_act_is_deferred'; did you mean 
'switchdev_port_obj_add'? [-Werror=implicit- function-declaration]
      640 |             switchdev_port_obj_act_is_deferred(dev, action, 
&mdb.obj)) {
          |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          |             switchdev_port_obj_add

  [ Fix ]

  Add a dummy implementation of switchdev_port_obj_act_is_deferred() for
  the CONFIG_NET_SWITCHDEV=n case. This approach was chosen because it
  is less risky and also requires minimal changes compared to the
  alternatives:

  * Backport 9776457c784f ("net: bridge: mdb: move all switchdev logic to 
br_switchdev.c"), which would involve resolving significant conflicts, or
  * Revert the CVE fix, cherry-pick nearly all prerequisite patches from [1] 
and [2], and then reapply the CVE fix.

  Note that register_switchdev_blocking_notifier() does nothing when
  CONFIG_NET_SWITCHDEV=n. Therefore, nbp_switchdev_(un)sync_objs (the
  sole caller of br_mdb_replay()) does not run in the first place.

  [1] 
https://lore.kernel.org/all/20211026142743.1298877-1-vladimir.olt...@nxp.com/
  [2] 
https://lore.kernel.org/all/20211027162119.2496321-1-vladimir.olt...@nxp.com/

  [ Test Plan ]

  Compile test with both CONFIG_NET_SWITCHDEV=y and
  CONFIG_NET_SWITCHDEV=n.

  [ Where problems could occur ]

  Any regressions caused by this tiny fix-the-fix patch should be caught
  during compilation.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2104380/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to