** Description changed: [Impact] r8169: enable SG/TSO on selected chip versions per default According to https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.13-rc6&id=b8bf38440ba94e8ed8e2ae55c5dfb0276d30e843, SG/TSO feature is ready for Linux kernel 6.12-rc4. [Fix] """"" commit b8bf38440ba94e8ed8e2ae55c5dfb0276d30e843 Author: Heiner Kallweit <hkallwe...@gmail.com> Date: Thu Oct 10 12:58:02 2024 +0200 - r8169: enable SG/TSO on selected chip versions per default + r8169: enable SG/TSO on selected chip versions per default - Due to problem reports in the past SG and TSO/TSO6 are disabled per - default. It's not fully clear which chip versions are affected, so we - may impact also users of unaffected chip versions, unless they know - how to use ethtool for enabling SG/TSO/TSO6. - Vendor drivers r8168/r8125 enable SG/TSO/TSO6 for selected chip - versions per default, I'd interpret this as confirmation that these - chip versions are unaffected. So let's do the same here. + Due to problem reports in the past SG and TSO/TSO6 are disabled per + default. It's not fully clear which chip versions are affected, so we + may impact also users of unaffected chip versions, unless they know + how to use ethtool for enabling SG/TSO/TSO6. + Vendor drivers r8168/r8125 enable SG/TSO/TSO6 for selected chip + versions per default, I'd interpret this as confirmation that these + chip versions are unaffected. So let's do the same here. - Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> - Reviewed-by: Simon Horman <ho...@kernel.org> - Signed-off-by: David S. Miller <da...@davemloft.net> + Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> + Reviewed-by: Simon Horman <ho...@kernel.org> + Signed-off-by: David S. Miller <da...@davemloft.net> - diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c - index 7287e841bbf172..30de7456522877 100644 - --- a/drivers/net/ethernet/realtek/r8169_main.c - +++ b/drivers/net/ethernet/realtek/r8169_main.c - @@ -5525,11 +5525,6 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) - - dev->features |= dev->hw_features; - - - /* There has been a number of reports that using SG/TSO results in - - * tx timeouts. However for a lot of people SG/TSO works fine. - - * Therefore disable both features by default, but allow users to - - * enable them. Use at own risk! - - */ - if (rtl_chip_supports_csum_v2(tp)) { - dev->hw_features |= NETIF_F_SG | NETIF_F_TSO | NETIF_F_TSO6; - netif_set_tso_max_size(dev, RTL_GSO_MAX_SIZE_V2); - @@ -5540,6 +5535,17 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) - netif_set_tso_max_segs(dev, RTL_GSO_MAX_SEGS_V1); - } - - + /* There has been a number of reports that using SG/TSO results in - + * tx timeouts. However for a lot of people SG/TSO works fine. - + * It's not fully clear which chip versions are affected. Vendor - + * drivers enable SG/TSO for certain chip versions per default, - + * let's mimic this here. On other chip versions users can - + * use ethtool to enable SG/TSO, use at own risk! - + */ - + if (tp->mac_version >= RTL_GIGA_MAC_VER_46 && - + tp->mac_version != RTL_GIGA_MAC_VER_61) - + dev->features |= dev->hw_features; - + - dev->hw_features |= NETIF_F_RXALL; - dev->hw_features |= NETIF_F_RXFCS; """"" https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/noble/tree/drivers/net/ethernet/realtek/r8169_main.c [Where problems could occur] When using iperf testing in the Ubuntu Certification Test Suite, The speed is only about 70%. (Expected result: Over 80%) This problem was initially discovered when the OS cert test suite was being executed. [Other Info] The OS scope in LENOVO is 24.04 server version, which are using Linux kernel 6.8, due to this reason, can this feature be backport to this version, thanks!
-- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/2094764 Title: Enable SG/TSO feature backport request for 24.04 server Status in linux package in Ubuntu: New Bug description: [Impact] r8169: enable SG/TSO on selected chip versions per default According to https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.13-rc6&id=b8bf38440ba94e8ed8e2ae55c5dfb0276d30e843, SG/TSO feature is ready for Linux kernel 6.12-rc4. [Fix] """"" commit b8bf38440ba94e8ed8e2ae55c5dfb0276d30e843 Author: Heiner Kallweit <hkallwe...@gmail.com> Date: Thu Oct 10 12:58:02 2024 +0200 r8169: enable SG/TSO on selected chip versions per default Due to problem reports in the past SG and TSO/TSO6 are disabled per default. It's not fully clear which chip versions are affected, so we may impact also users of unaffected chip versions, unless they know how to use ethtool for enabling SG/TSO/TSO6. Vendor drivers r8168/r8125 enable SG/TSO/TSO6 for selected chip versions per default, I'd interpret this as confirmation that these chip versions are unaffected. So let's do the same here. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> Reviewed-by: Simon Horman <ho...@kernel.org> Signed-off-by: David S. Miller <da...@davemloft.net> """"" https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/noble/tree/drivers/net/ethernet/realtek/r8169_main.c [Where problems could occur] When using iperf testing in the Ubuntu Certification Test Suite, The speed is only about 70%. (Expected result: Over 80%) This problem was initially discovered when the OS cert test suite was being executed. [Other Info] The OS scope in LENOVO is 24.04 server version, which are using Linux kernel 6.8, due to this reason, can this feature be backport to this version, thanks! To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2094764/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
