Hi Joao, Thanks for your work on this bug and the SRU. I reviewed the LP bug and packaging changes in your PPA.
Things are almost good to go; congrats! Please ack/adjust these points and let me know, so I can review/upload. cheers, Mauricio ... LP bug review: LP#2081611 --- - Link [1] should be updated to the new SRU docs. - Test Plan's part A (current/unaffected sytems) should be executed with the test package as well. According to bug comments, only part B (newer/affected systems) was performed, and no `diff` was provided as in test plan (used different -t levels before/after) - Test Plan should be executed for all Ubuntu series with changes (Noble _and_ Jammy, in this bug) - Ideally, please have the Test Plan executed with the test packages _before_ we upload the SRU and it gets in -proposed. (Identifying and addressing issues earlier/before -proposed is always easier and less time consuming than in -proposed.) Packaging review: ppa:jasimioni/dmidecode-lp2081611 --- A) Noble: https://launchpad.net/~jasimioni/+archive/ubuntu/dmidecode-lp2081611/+files/dmidecode_3.5-3build1_3.5-3build1ubuntu1.diff.gz - Version: 3.5-3build1ubuntu1 -> 3.5-3ubuntu0.1 (Reference: https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging) - Changelog entry: just a summary (details go in the .patch file), e.g., * d/p/lp-2081611-0001-add-processor-support-from-smbios-3.6.0.patch: Add processor support from SMBIOS 3.6.0 (LP: #2081611) Note that the 'LP: #<number>' format must be exactly like this, so that LP can find it and reference the bug for comments/status updates. - Patch file: lp-2081611-0001-add-processor-support-from-smbios-3.6.0.patch Since this is adding only one patch, you can remove the 0001 counter. Add DEP-3 headers: https://dep-team.pages.debian.net/deps/dep3/ For git patches, you only need to add these 2, preferably at the top: Bug-Ubuntu: https://bugs.launchpad.net/bugs/<number> Origin: <upstream|backport>, https://git web url for the commit (upstream is for no changes to the upstream patch were required to apply; backport is for any changes to the upstream patch were required to apply) For an example, see Jammy's LP debdiff which also showed the previous SRU with lp1986852-0001-Add-new-memory-device-types-from-SMBIOS-spec-3.4.0.patch B) Jammy: https://launchpadlibrarian.net/750734184/dmidecode_3.3-3_3.3-3ubuntu0.2.diff.gz - Version: correct - Changelog entry: likewise - Patch file: likewise ** Changed in: dmidecode (Ubuntu Jammy) Status: New => Incomplete ** Changed in: dmidecode (Ubuntu Noble) Status: New => Incomplete ** Changed in: dmidecode (Ubuntu Jammy) Importance: Undecided => Medium ** Changed in: dmidecode (Ubuntu Noble) Importance: Undecided => Medium ** Changed in: dmidecode (Ubuntu Jammy) Assignee: (unassigned) => Joao Andre Simioni (jasimioni) ** Changed in: dmidecode (Ubuntu Noble) Assignee: (unassigned) => Joao Andre Simioni (jasimioni) -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to dmidecode in Ubuntu. https://bugs.launchpad.net/bugs/2081611 Title: Add processor support from SMBIOS 3.6.0 in Jammy and Noble Status in dmidecode package in Ubuntu: Fix Released Status in dmidecode source package in Jammy: Incomplete Status in dmidecode source package in Noble: Incomplete Bug description: [Impact] * Add processor support from SMBIOS 3.6.0 in Jammy and Noble to enable new hardware in LTS release per SRU policy [1]. * Backport of 1 relatively simple patch from dmidecode 3.6 in Oracular to dmidecode 3.3 in Jammy and dmidecode 3.5 in Noble [Test Plan] * Check no regressions on current systems with SMBIOS < 3.6, i.e., no output changes in text and binary form. $ sudo dmidecode > old.txt 2>&1 $ sudo dmidecode --dump-bin old.bin $ apt install dmidecode # modified package $ sudo dmidecode > new.txt 2>&1 $ sudo dmidecode --dump-bin new.bin $ cmp old.txt new.txt; echo $? 0 $ cmp old.bin new.bin; echo $? 0 * Check for expected output on new systems with SMBIOS >= 3.6. $ diff old.txt new.txt 1) Run "sudo dmidecode -t4" 2) Observe that the "Thread Enabled" field is being reported [1] https://wiki.ubuntu.com/StableReleaseUpdates#Other_safe_cases [Patch Details] https://git.savannah.nongnu.org/cgit/dmidecode.git/commit/?id=ac65cf23af7cccecb4175d3c13460928e8e2f51d Commit ac65cf23af7cccecb4175d3c13460928e8e2f51d Author: Jean Delvare <jdelv...@suse.de> Date: Fri May 26 17:41:51 2023 +0200 dmidecode: Add processor support from SMBIOS 3.6.0 SMBIOS 3.6.0 adds the following to the Processor Information structure (type 4): * 9 socket types * 1 processor family * 1 field (Thread Enabled) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dmidecode/+bug/2081611/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
